Support if-let guards in matches macros by using :guard matcher#156025
Open
SpriteOvO wants to merge 2 commits intorust-lang:mainfrom
Open
Support if-let guards in matches macros by using :guard matcher#156025SpriteOvO wants to merge 2 commits intorust-lang:mainfrom
matches macros by using :guard matcher#156025SpriteOvO wants to merge 2 commits intorust-lang:mainfrom
Conversation
4 tasks
Member
Author
Alternatively, to be more safe, we only provide the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue #153104.
This PR replaces the original
if $guard:exprwith new matcher$guard:guardin macrosmatches!andassert_matches!to support the use of if-let guards syntax in these macros. This syntax is already stable in #141295 formatcharms.Please note that this PR directly applies
:guardto macros that are already stable, so the support for if-let guards in these macros is instantly stable.When using these macros that accept
:guard, users will not be required to use nightly and enable#![feature(macro_guard_matcher)]. However, when defining macros with:guard, nightly and#![feature(macro_guard_matcher)]are still required. Therefore, I think a Crater run is needed.cc @programmerjake
r? libs